both of them can actually yield some profit both on short-term or on long-term but trading can actually be much profitable because in trading the little profit you get on every successful trading will be taken out but in saving you will not take it out even if the market is going up and down.saving is always for a long time for maximum profit